[WIP] Split Queue handling and DB writing to address #1216 #1236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #1216, this PR splits the ES into two separate services:
1- QueueService: This service is solely responsible for maintaining the queue. It assigns tasks to the worker. Once the results are ready it receives them and assigns it to an ES to write to database. Once done, QueueService asks ES to also create next step operations and push them to the queue. In this way, there is no time consuming process being done in the QueueService itself which allows it to always be available. The only exception currently is finding missing operations and invalidating a submission. But these happen less regularly.
2- EvaluationService: This service handles the time consuming tasks needed for maintaining the queue (e.g. writing to the database and computing new operations). The current implementation also allows for multiple ES to be running. I am considering renaming this to QueueWorkerService.
The PR is currently WIP because there are some tasks left:
But I wanted to see if there are any comments in advance before finalizing.