Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Split Queue handling and DB writing to address #1216 #1236

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

akmohtashami
Copy link
Contributor

To address #1216, this PR splits the ES into two separate services:

1- QueueService: This service is solely responsible for maintaining the queue. It assigns tasks to the worker. Once the results are ready it receives them and assigns it to an ES to write to database. Once done, QueueService asks ES to also create next step operations and push them to the queue. In this way, there is no time consuming process being done in the QueueService itself which allows it to always be available. The only exception currently is finding missing operations and invalidating a submission. But these happen less regularly.

2- EvaluationService: This service handles the time consuming tasks needed for maintaining the queue (e.g. writing to the database and computing new operations). The current implementation also allows for multiple ES to be running. I am considering renaming this to QueueWorkerService.

The PR is currently WIP because there are some tasks left:

  • Making sure dequeuing an operation fails when it is being written by ES (there is no way to cancel this so we can only fail)
  • Some final clean ups

But I wanted to see if there are any comments in advance before finalizing.

@akmohtashami akmohtashami changed the title [WIP] Split Queue handling and DB writing to address #1216 Split Queue handling and DB writing to address #1216 Jul 12, 2023
@akmohtashami akmohtashami changed the title Split Queue handling and DB writing to address #1216 [WIP] Split Queue handling and DB writing to address #1216 Jul 12, 2023
@wil93
Copy link
Member

wil93 commented Jan 18, 2024

I am considering renaming this to QueueWorkerService.

Maybe even just QueueWorker? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants