Use docker-compose to run tests #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the testing logic from the Github Actions format to a more easy to reproduce docker-compose file.
Codecov Report
@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
- Coverage 63.51% 63.44% -0.07%
==========================================
Files 233 233
Lines 17151 17151
==========================================
- Hits 10893 10882 -11
- Misses 6258 6269 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
stefano-maggiolo
approved these changes
Dec 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the testing logic from the Github Actions format to a
docker-compose.test.ymlfile. The advantage of this approach is that we can now run tests locally in a easy and reproducible way.Moreover, instead of using
sedat runtime to inject the test database string intocms.conf, we now always add acms-testdb.conffile next tocms.confin the/usr/local/etc/folder as part of the build step of the docker container. We then decide which config file to use based on the already-supportedCMS_CONFIGenvironment variable. (I had to patchtestrunner.pywhich was not supporting that variable yet.)One possible next step in this direction could be using this approach also for local development, with a
cms-devdb.conffile which likewise always gets copied in the etc folder, and adocker-compose.dev.ymlwhich uses it to start the DB and the local CMS instance. It's also possible to re-use theDockerfilein production, but I wouldn't try to support that use case seriously just yet (I think the contest admins can write adocker-compose.ymlfitting their specific needs).