Join contest with current account #1191
Merged
+199
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1191 +/- ##
==========================================
- Coverage 63.56% 63.38% -0.19%
==========================================
Files 233 233
Lines 17117 17139 +22
==========================================
- Hits 10881 10864 -17
- Misses 6236 6275 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
andreyv
reviewed
Oct 26, 2021
andreyv
requested changes
Nov 29, 2021
There are 2 tabs, one for creating new user and one for register with an existing account. Note that the register page sould be scrollable because of the long form inside it. So it can not use login_box class.
The previous method had 2 different forms but the new method has a single form and just disables extra fields if they're unused
|
I applied the above suggestions and revised translatable strings in c0b9978. Everything looks good now 🙂 I'll merge this in a few days if there are no further comments. |
andreyv
approved these changes
Dec 20, 2021
|
Merging. |
RezwanArefin01
pushed a commit
to RezwanArefin01/cms
that referenced
this pull request
Dec 27, 2021
* Update user interface to support joining to contests There are 2 tabs, one for creating new user and one for register with an existing account. Note that the register page sould be scrollable because of the long form inside it. So it can not use login_box class. * Implement logic of join contest without user creation * Add contributor's name and copyright * Check participations only when joining a contest * Disable and hide register fields when joining to contest The previous method had 2 different forms but the new method has a single form and just disables extra fields if they're unused * Clear field errors after each tab switch * Small updates Co-authored-by: Andrey Vihrov <andrey.vihrov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented this feature based on the #1187 discussions.
However it's my first serious contribution to cms, so I'll be pleased if you guide me in case I've done anything wrong or unclean.