Migrate CI to GitHub Actions #1176
Conversation
|
Sample CI job results: https://github.com/ioi-2022/cms/actions/runs/747025045 |
|
Hi, Thanks for the PR, the idea sounds great. I'll take a look at the details a little bit later. |
There was a problem hiding this comment.
Please see some comments below.
I noticed the following in the new build log, too:
- Multiple warnings such as
Using legacy 'setup.py install' for netifaces, since package 'wheel' is not installed. - Python packages, and CMS itself (!), are installed to, e.g.,
/opt/hostedtoolcache/Python/3.8.8/x64/lib/python3.8/site-packages, which doesn't really look like a user directory. Not sure if this is the intended way.
I will also be running some experiments with Github Actions to better understand the problems with the user group and isolate, and the warnings as well.
|
Will take a look at other comments later this week! |
It can happen that the CMS user's primary group name doesn't match the user name (in case of a pre-existing user), so we should use the actual group name for setting file permissions. We don't try to always create and use a "cmsuser" group instead, because this wouldn't work within a single CI session.
|
I also investigated this further today and found the cause. In the CI environment, the user is After fixing this problem I could remove the three workaround actions in the Regarding the pip warnings, I don't have permissions to edit this branch, but you can see the new changes in 80091ce and 5678b3f. The CI now passes. I'm inclined to merge this tomorrow unless you have any additional comments. And thanks for preparing the PR! [1] https://docs.github.com/en/actions/guides/building-and-testing-python |
|
Ah, thanks for investigating and fixing the issue! I've cherry-picked your fix and included the commit in this branch. The CI passed here: https://github.com/ioi-2022/cms/actions/runs/810455275. Now this PR should be good to go 😄 |
|
Merged, thanks :) |
Migrating CI to GitHub's native CI tools (GitHub actions) so that we don't need to rely on external site (Travis) anymore.
This change is