New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show original IP address of requests in AWS logs #1131

Merged

andreyv merged 1 commit into cms-dev:master from andreyv:aws-original-ip

Feb 17, 2021

Member

andreyv commented Aug 22, 2019 •

edited by stefano-maggiolo

Loading

See also the previous discussion: https://gitter.im/cms-dev/cms?at=5bfa905597a8982b9a606c79

For now I implemented a bare-bones approach with the hidden config setting. It can be developed further:

Either by documenting the new setting in cms.conf
Or by refactoring num_proxies_used to include both CWS and AWS

I can rework this PR if needed.

This change is


          Show original IP address of requests in AWS logs

b600728

Member Author

andreyv commented Feb 17, 2021

Let's make the new setting separate. Initializing it from num_proxies_used by default may have security implications.

andreyv merged commit 9236084 into cms-dev:master

andreyv deleted the aws-original-ip branch

February 17, 2021 16:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet