Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show ranking credentials in ProxyService logs #1129

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Do not show ranking credentials in ProxyService logs #1129

merged 1 commit into from
Feb 11, 2021

Conversation

andreyv
Copy link
Member

@andreyv andreyv commented Aug 18, 2019

This was more complex than it should've been 😮


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #1129 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1129      +/-   ##
==========================================
- Coverage   61.99%   61.98%   -0.02%     
==========================================
  Files         230      230              
  Lines       16604    16610       +6     
==========================================
+ Hits        10294    10296       +2     
- Misses       6310     6314       +4
Flag Coverage Δ
#functionaltests 45.68% <100%> (+0.09%) ⬆️
#unittests 43.3% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
cms/service/ProxyService.py 60.82% <100%> (+1.78%) ⬆️
cms/grading/Job.py 85.3% <0%> (-3.8%) ⬇️
cms/service/esoperations.py 77.3% <0%> (-1.42%) ⬇️
cms/server/admin/handlers/task.py 39.84% <0%> (-1.18%) ⬇️
cms/service/EvaluationService.py 66.48% <0%> (-1.07%) ⬇️
cms/io/rpc.py 90.1% <0%> (-1.03%) ⬇️
cms/io/service.py 68.9% <0%> (-0.61%) ⬇️
cms/server/admin/handlers/dataset.py 25.38% <0%> (-0.31%) ⬇️
cms/db/base.py 84.04% <0%> (ø) ⬆️
cms/grading/Sandbox.py 68.23% <0%> (+0.36%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c9e92...9520193. Read the comment docs.

@andreyv andreyv merged commit aefc539 into cms-dev:master Feb 11, 2021
@andreyv andreyv deleted the ranking-log branch February 11, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant