Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone field in italy_yaml format #1098

Merged
merged 1 commit into from
Jan 13, 2019

Conversation

lucach
Copy link
Contributor

@lucach lucach commented Jan 11, 2019

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #1098 into master will increase coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
+ Coverage      62%   62.17%   +0.17%     
==========================================
  Files         230      230              
  Lines       16585    16586       +1     
==========================================
+ Hits        10284    10313      +29     
+ Misses       6301     6273      -28
Flag Coverage Δ
#functionaltests 45.96% <0%> (+0.25%) ⬆️
#unittests 43.27% <0%> (+0.02%) ⬆️
Impacted Files Coverage Δ
cmscontrib/loaders/italy_yaml.py 7.93% <0%> (-0.02%) ⬇️
cms/db/base.py 85.1% <0%> (-6.39%) ⬇️
cms/db/util.py 51.11% <0%> (-1.49%) ⬇️
cms/service/EvaluationService.py 68.35% <0%> (+0.26%) ⬆️
cms/server/admin/handlers/base.py 71.18% <0%> (+0.33%) ⬆️
cms/io/rpc.py 91.8% <0%> (+0.34%) ⬆️
cms/grading/Sandbox.py 68.59% <0%> (+0.36%) ⬆️
cms/service/ProxyService.py 57.97% <0%> (+0.53%) ⬆️
cms/io/service.py 70.12% <0%> (+0.6%) ⬆️
cms/service/esoperations.py 80.85% <0%> (+0.7%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc03cb...1ddfffc. Read the comment docs.

Copy link
Member

@stefano-maggiolo stefano-maggiolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@stefano-maggiolo stefano-maggiolo merged commit 1ddfffc into cms-dev:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants