Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in delete_sandbox() warning #1092

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Fix grammar in delete_sandbox() warning #1092

merged 1 commit into from
Dec 13, 2018

Conversation

andreyv
Copy link
Member

@andreyv andreyv commented Dec 12, 2018

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #1092 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1092      +/-   ##
=========================================
+ Coverage   61.97%   62.2%   +0.23%     
=========================================
  Files         229     229              
  Lines       16520   16520              
=========================================
+ Hits        10238   10276      +38     
+ Misses       6282    6244      -38
Flag Coverage Δ
#functionaltests 46.06% <0%> (+0.58%) ⬆️
#unittests 43.31% <100%> (ø) ⬆️
Impacted Files Coverage Δ
cms/grading/tasktypes/util.py 87.2% <100%> (ø) ⬆️
cms/server/admin/handlers/task.py 39.84% <0%> (-1.18%) ⬇️
cms/server/admin/handlers/base.py 67.45% <0%> (+0.33%) ⬆️
cms/grading/Sandbox.py 68.23% <0%> (+0.36%) ⬆️
cms/service/workerpool.py 62.22% <0%> (+0.55%) ⬆️
cms/io/service.py 69.51% <0%> (+0.6%) ⬆️
cms/server/admin/handlers/dataset.py 25.38% <0%> (+0.61%) ⬆️
cms/db/filecacher.py 77.7% <0%> (+0.65%) ⬆️
cms/io/rpc.py 92.49% <0%> (+1.02%) ⬆️
cms/service/EvaluationService.py 67.81% <0%> (+1.06%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98cf4d5...9335527. Read the comment docs.

@stefano-maggiolo stefano-maggiolo merged commit 9335527 into cms-dev:master Dec 13, 2018
@andreyv andreyv deleted the sandbox-warning-grammar branch December 13, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants