Fix custom PostgreSQL domains not being used in table definitions #1073
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
=========================================
+ Coverage 62.05% 62.1% +0.05%
=========================================
Files 228 229 +1
Lines 16457 16521 +64
=========================================
+ Hits 10212 10260 +48
- Misses 6245 6261 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Do we really need to backport?
Also, shouldn't we bump db version and copy the updater?
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
The reason for backporting is that we just got a bug report due to this. I added a no-op updater that just prints a message and fails if any data is invalid. Is this what you had in mind? |
There was a problem hiding this comment.
Uhm, I was thinking at copying update_26.py, but a failure is fine too.
I'm not too keen in backporting something that requires a db update when it's not fixing a too important bug, and that bug had been present for a long time. Opinions?
Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @codacy-bot and @lerks)
isolate, line 1 at r2 (raw file):
Subproject commit 5d6beb258e995cf4b0c982ff98cbbc0e9e127853
Intended?
cmscontrib/updaters/update_41.py, line 24 at r2 (raw file):
This updater makes sure filenames contain no percent sign, except in a trailing ".%l", if any.
Wrong comment? Possibly mention that this is a duplicare and the reason.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @codacy-bot and @lerks)
cmscontrib/updaters/update_41.py, line 20 at r2 (raw file):
"""A class to update a dump created by CMS.
Would be nice to print what is wrong - the idea is that people might have created bad names between db 26 and now, and so they might legitimately have bad names not for their fault.
There was a problem hiding this comment.
We can avoid backporting now, and do it if this bug starts biting too many people.
Dismissed @codacy-bot from a discussion.
Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @stefano-maggiolo)
cmscontrib/updaters/update_41.py, line 20 at r2 (raw file):
Previously, stefano-maggiolo (Stefano Maggiolo) wrote…
Would be nice to print what is wrong - the idea is that people might have created bad names between db 26 and now, and so they might legitimately have bad names not for their fault.
Done.
cmscontrib/updaters/update_41.py, line 24 at r2 (raw file):
Previously, stefano-maggiolo (Stefano Maggiolo) wrote…
Wrong comment? Possibly mention that this is a duplicare and the reason.
Done.
isolate, line 1 at r2 (raw file):
Previously, stefano-maggiolo (Stefano Maggiolo) wrote…
Intended?
No, dunno how that happened, reverted
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @stefano-maggiolo and @codacy-bot)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @codacy-bot)
There was a problem hiding this comment.
Dismissed @codacy-bot from a discussion.
Reviewable status:
Spotted thanks to #1071.
Needs to be backported to v1.4.
This change is