Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML fixes #1064

Merged
merged 1 commit into from
Nov 4, 2018
Merged

HTML fixes #1064

merged 1 commit into from
Nov 4, 2018

Conversation

andreyv
Copy link
Member

@andreyv andreyv commented Nov 4, 2018

Also add missing style for the empty print job table case. Perhaps the table may benefit from more extensive styling, like with the submission and the user test tables, but this change fixes the immediate visual problem.


This change is Reviewable

Also add missing style for the empty print job table case. Perhaps the
table may benefit from more extensive styling, like with the submission
and the user test tables, but this change fixes the immediate visual
problem.
@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #1064 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   61.97%   62.02%   +0.04%     
==========================================
  Files         228      228              
  Lines       16436    16436              
==========================================
+ Hits        10186    10194       +8     
+ Misses       6250     6242       -8
Flag Coverage Δ
#functionaltests 46.06% <ø> (ø) ⬆️
#unittests 43.16% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
cms/db/base.py 81.91% <0%> (-2.13%) ⬇️
cms/server/contest/handlers/taskusertest.py 42.42% <0%> (-1.22%) ⬇️
cms/service/workerpool.py 61.66% <0%> (-1.12%) ⬇️
cms/grading/Job.py 88.62% <0%> (-0.95%) ⬇️
cms/io/priorityqueue.py 92.7% <0%> (-0.73%) ⬇️
cms/server/admin/handlers/base.py 67.45% <0%> (-0.68%) ⬇️
cms/server/admin/handlers/user.py 28.12% <0%> (-0.63%) ⬇️
cms/io/rpc.py 90.78% <0%> (-0.35%) ⬇️
cms/io/service.py 69.51% <0%> (+0.6%) ⬆️
cms/server/admin/handlers/dataset.py 25.38% <0%> (+0.61%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8a701...ef88f90. Read the comment docs.

Copy link
Member

@lw lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lw lw merged commit cb8a533 into cms-dev:master Nov 4, 2018
@lw
Copy link
Member

lw commented Nov 4, 2018

Thanks for doing these checks! Merged in master and v1.4.

@andreyv andreyv deleted the html-fixes branch November 5, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants