Manage PdfFileMerger object in a with statement

cms-dev · Dec 16, 2020 · f4e3936 · f4e3936
1 parent 1f5630a
commit f4e3936
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/cms/service/PrintingService.py b/cms/service/PrintingService.py
@@ -26,6 +26,7 @@
 import os
 import subprocess
 import tempfile
+import contextlib
 
 from PyPDF2 import PdfFileReader, PdfFileMerger
 from jinja2 import PackageLoader
@@ -189,12 +190,11 @@ def execute(self, entry):
                     "Failed to create title page with command: %s"
                     "(error %d)" % (pretty_print_cmdline(cmd), ret))
 
-            pdfmerger = PdfFileMerger()
-            pdfmerger.append(title_pdf)
-            pdfmerger.append(source_pdf)
-            result = os.path.join(directory, "document.pdf")
-            pdfmerger.write(result)
-            pdfmerger.close()
+            with contextlib.closing(PdfFileMerger()) as pdfmerger:
+                pdfmerger.append(title_pdf)
+                pdfmerger.append(source_pdf)
+                result = os.path.join(directory, "document.pdf")
+                pdfmerger.write(result)
 
             try:
                 printer_connection = cups.Connection()