Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial upload of data files needed for the RecoTracker/LSTCore CMSSW package #1

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

VourMa
Copy link

@VourMa VourMa commented Jun 1, 2024

This PR includes the needed data files for the newly proposed RecoTracker/LSTCore CMSSW pakage to run.

@slava77 @ariostas

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2024

A new Pull Request was created by @VourMa for branch main.

@cmsbuild, @mandrenguyen, @iarspider, @aandvalenzuela, @smuzaffar, @jfernan2 can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2024

cms-bot internal usage

@VourMa VourMa mentioned this pull request Jun 1, 2024
3 tasks
@slava77
Copy link

slava77 commented Jun 4, 2024

to avoid constant interference from unrelated commit merges in the PR tests of cms-sw/cmssw#45117, perhaps this PR can be merged already?

Otherwise the presence of this data PR in the dependency of cms-sw/cmssw#45117 triggers the bot to include everything between the last IB and the head of cmsdist and cms-sw master.

@mandrenguyen
Copy link

+1

@slava77
Copy link

slava77 commented Jun 4, 2024

@smuzaffar
now that reco has signed off, perhaps this PR can be signed by externals and merged?

@smuzaffar
Copy link

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

This pull request is fully signed and it will be integrated in one of the next main IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@slava77
Copy link

slava77 commented Jun 4, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a9f04/39700/summary.html
COMMIT: 7740d3b
CMSSW: CMSSW_14_1_X_2024-06-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoTracker-LSTCore/1/39700/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338842
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link

slava77 commented Jun 6, 2024

@cms-sw/orp-l2

to avoid constant interference from unrelated commit merges in the PR tests of cms-sw/cmssw#45117, perhaps this PR can be merged already?

Otherwise the presence of this data PR in the dependency of cms-sw/cmssw#45117 triggers the bot to include everything between the last IB and the head of cmsdist and cms-sw master.

@slava77
Copy link

slava77 commented Jun 6, 2024

@antoniovilela, @sextonkennedy, @rappoccio

to avoid constant interference from unrelated commit merges in the PR tests of cms-sw/cmssw#45117, perhaps this PR can be merged already?

Otherwise the presence of this data PR in the dependency of cms-sw/cmssw#45117 triggers the bot to include everything between the last IB and the head of cmsdist and cms-sw master.

@antoniovilela
Copy link

+1

@cmsbuild cmsbuild merged commit fb4158d into cms-data:main Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants