Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GloParT model (a placeholder) #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

colizz
Copy link

@colizz colizz commented Aug 28, 2024

This PR aims to add the GloParT 3 model prepared for NanoAODv15. The topic has been discussed on Monday's JMAR meeting [slides].

The current ONNX model serves as a placeholder for incorporating the PR into CMSSW. As discussed in the meeting, the CMSSW PR will be finalized this week, while we have approximately three additional weeks to finalize the GloParT 3 model.

For context, during our development history, GloParT 2 has already been validated to function properly within CMSSW (using this branch: https://github.com/colizz/cmssw/tree/dev-130X-glopart), although it has not been integrated. We are now in the final stages of upgrading from version 2 to version 3, and the GloParT 3 model will be uploaded within 2-3 weeks.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @colizz for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @jfernan2, @mandrenguyen, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #61 was updated.

@mandrenguyen
Copy link
Contributor

If this is no longer a placeholder, please update the title.

@colizz
Copy link
Author

colizz commented Sep 17, 2024

If this is no longer a placeholder, please update the title.

Thanks for your reminder! It's still a placeholder by far - we uploaded the beta1 model here for the initial performance test at cms-sw/cmssw#45830. We will update the title (or make a new PR if we don't want the repository size to increase too much) after the final model is uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants