Adding ZDC LUT for use with L1TZDC Emulator; to be pushed to cms-data… #23

cfmcginn · 2023-08-29T15:05:48Z

LUT for L1TZDCProducer, emulator of ZDC l1 trigger for 2023 HI datataking - PR in progress to cmssw here:

cms-sw/cmssw#42634

Simultaneous PR to cms-l1t-offline/L1Trigger-L1TCalorimeter here:

cms-l1t-offline#20

Tagging a few people to track - @ginnocen @bundocka @aloeliger

…; PR to cms-l1t-iffline already in progress

cmsbuild · 2023-08-29T15:06:10Z

A new Pull Request was created by @cfmcginn (Chris) for branch master.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

aloeliger · 2023-08-31T08:26:57Z

please test

cmsbuild · 2023-08-31T09:10:09Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c59d2f/34554/summary.html
COMMIT: 6a8af5a
CMSSW: CMSSW_13_3_X_2023-08-30-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-L1TCalorimeter/23/34554/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

AddOn Tests

read312RV

----- Begin Fatal Exception 31-Aug-2023 11:04:29 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-08-30-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py
Exception Message:
 unknown python problem occurred.
ModuleNotFoundError: No module named 'past'

At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-08-30-2300/src/FWCore/ParameterSet/python/Types.py(6): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-08-30-2300/src/FWCore/ParameterSet/python/Config.py(15): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-08-30-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py(2): <module>

----- End Fatal Exception -------------------------------------------------

fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 0 sec (ended on Thu Aug 31 11:04:34 2023) - exit: 256

fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 0 sec (ended on Thu Aug 31 11:04:39 2023) - exit: 256

Expand to see more addon errors ...

aloeliger · 2023-08-31T09:13:11Z

@cfmcginn According to your email today, it seems like externals really aren't actually the place for this. We need to instead discuss with the o2o/db experts.

aloeliger · 2023-08-31T21:42:20Z

@cfmcginn According to your email today, it seems like externals really aren't actually the place for this. We need to instead discuss with the o2o/db experts.

After further discussion, perhaps this is the correct location for this for the time being, the relative rate of change of this LUT may be such that having it in the externals for testing while a db solution is created is desirable.

aloeliger · 2023-08-31T21:43:16Z

@smuzaffar The test failures are complaining largely about past, which is core python stuff. Is this just a transient python error?

cfmcginn · 2023-08-31T21:52:19Z

@cfmcginn According to your email today, it seems like externals really aren't actually the place for this. We need to instead discuss with the o2o/db experts.

After further discussion, perhaps this is the correct location for this for the time being, the relative rate of change of this LUT may be such that having it in the externals for testing while a db solution is created is desirable.

Understood - please let me know if these test failures require changes by me, will iterate.

smuzaffar · 2023-08-31T22:15:16Z

test parameters:

pull_request = L1T ZDC and uGT Emulator to CMSSW_13_3_X cms-sw/cmssw#42634

smuzaffar · 2023-08-31T22:16:10Z

please test

@smuzaffar The test failures are complaining largely about past, which is core python stuff. Is this just a transient python error?

I guess it needs cmssw PR to run properly ?

cmsbuild · 2023-09-01T05:29:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c59d2f/34568/summary.html
COMMIT: 6a8af5a
CMSSW: CMSSW_13_3_X_2023-08-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-L1TCalorimeter/23/34568/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c59d2f/34568/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c59d2f/34568/git-merge-result

Comparison Summary

Summary:

You potentially added 28 lines to the logs
Reco comparison results: 331 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3153350
DQMHistoTests: Total failures: 119
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153209
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

aloeliger · 2023-09-01T09:22:29Z

+l1

rappoccio · 2023-09-01T15:29:08Z

+1

rappoccio · 2023-09-01T15:29:12Z

merge

Adding ZDC LUT for use with L1TZDC Emulator; to be pushed to cms-data…

6a8af5a

…; PR to cms-l1t-iffline already in progress

cmsbuild added orp-pending pending-signatures externals-pending tests-pending l1-pending labels Aug 29, 2023

cmsbuild added tests-started and removed tests-pending labels Aug 31, 2023

aloeliger mentioned this pull request Aug 31, 2023

L1T ZDC and uGT Emulator to CMSSW_13_3_X cms-sw/cmssw#42634

Merged

cmsbuild added tests-rejected and removed tests-started labels Aug 31, 2023

cmsbuild added the requires-external label Aug 31, 2023

cmsbuild added tests-started and removed tests-rejected labels Aug 31, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 1, 2023

cmsbuild added l1-approved and removed l1-pending labels Sep 1, 2023

cmsbuild added orp-approved and removed orp-pending labels Sep 1, 2023

cmsbuild merged commit 606b6c9 into cms-data:master Sep 1, 2023

cmsbuild mentioned this pull request Sep 1, 2023

Update tag for L1Trigger-L1TCalorimeter to V01-02-00 cms-sw/cmsdist#8677

Merged

perrotta mentioned this pull request Sep 1, 2023

L1T ZDC and uGT Emulator Backport cms-sw/cmssw#42706

Merged

missirol mentioned this pull request Sep 2, 2023

add support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT [13_2_X] cms-sw/cmssw#42708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding ZDC LUT for use with L1TZDC Emulator; to be pushed to cms-data… #23

Adding ZDC LUT for use with L1TZDC Emulator; to be pushed to cms-data… #23

cfmcginn commented Aug 29, 2023

cmsbuild commented Aug 29, 2023

aloeliger commented Aug 31, 2023

cmsbuild commented Aug 31, 2023

aloeliger commented Aug 31, 2023

aloeliger commented Aug 31, 2023

aloeliger commented Aug 31, 2023

cfmcginn commented Aug 31, 2023

smuzaffar commented Aug 31, 2023

smuzaffar commented Aug 31, 2023

cmsbuild commented Sep 1, 2023

aloeliger commented Sep 1, 2023

rappoccio commented Sep 1, 2023

rappoccio commented Sep 1, 2023

Adding ZDC LUT for use with L1TZDC Emulator; to be pushed to cms-data… #23

Adding ZDC LUT for use with L1TZDC Emulator; to be pushed to cms-data… #23

Conversation

cfmcginn commented Aug 29, 2023

cmsbuild commented Aug 29, 2023

aloeliger commented Aug 31, 2023

cmsbuild commented Aug 31, 2023

RelVals

AddOn Tests

aloeliger commented Aug 31, 2023

aloeliger commented Aug 31, 2023

aloeliger commented Aug 31, 2023

cfmcginn commented Aug 31, 2023

smuzaffar commented Aug 31, 2023

smuzaffar commented Aug 31, 2023

cmsbuild commented Sep 1, 2023

Comparison Summary

aloeliger commented Sep 1, 2023

rappoccio commented Sep 1, 2023

rappoccio commented Sep 1, 2023