Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced configuration #87
Reduced configuration #87
Changes from all commits
0ca1244
4dd1ae7
e2f7220
5058dc1
7b470a8
5b5b999
baa855c
dac7a8a
045e4ec
957ae5c
c271c10
783f0c5
adf9fa0
fceaf2a
5cc5bb1
4144547
20b9b5a
77bd6bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will you make files data/reduced*.dat available? Will you put them in a fork of https://github.com/cms-data/L1Trigger-TrackTrigger.git ? N.B. They can go in our development branch, but should never go into central CMSSW, since the summer chain is temporary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the PR in the initial comment:
cms-L1TK/L1Trigger-TrackFindingTracklet#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comment at L69 is wrong. Surely the InputRouter writes to the InputLinkMemory, not the AllStubs memories? And why is L77 required. In your reduced chain, do some InputRouter write to no output memories? This would seem odd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trholmes any answer to this comment?