Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTC_merge2 branch updated to 1130 #74

Merged
merged 48 commits into from
Apr 11, 2021
Merged
Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
67f080b
Anders DTC merge with a gazillion manual fixes
skinnari Mar 2, 2021
8e775d1
propagate buildfile fixes
skinnari Mar 2, 2021
650ff58
code formats
skinnari Mar 2, 2021
b140ffe
fix cherrypick mess up
skinnari Mar 2, 2021
04d9dfa
Remove LayerProjection class
Mar 2, 2021
549ac30
Further cleanup of tracklet projections interface
Mar 3, 2021
e647457
Correct number of processing steps by changing < to <=
aryd Mar 6, 2021
b51b039
Add missing include of algorithm
aryd Mar 7, 2021
cf5498d
Remove extra const
aryd Mar 8, 2021
1bf7df1
Remove some commented out code
Mar 8, 2021
936da8a
Remove duplicate code
Mar 8, 2021
314eb77
Fix message logger and DTC Stub for consistency with hybrid configura…
aryd Mar 9, 2021
0371772
Fix problem with writing of input link memories
Mar 9, 2021
c9c646a
Create Residual class that will replace LayerResidual and DiskResidual
Mar 10, 2021
da78939
Remove the use of the class DiskResiduals
Mar 10, 2021
5f76609
Remove unused nMatch and nMatchDisk method of Tracklet
Mar 10, 2021
a181be9
(Re-)Implement the correction to writing the DTC data link file after…
Mar 11, 2021
946b120
Combine addMatch method for disk and layers into on method
Mar 11, 2021
4c6a774
combine the disk and layer match into one method
Mar 11, 2021
6255829
Remove some redundant poiters to l1tstubs
Mar 11, 2021
c19d68d
Pass iSeed to Tracklet
Mar 11, 2021
52d12b8
Introduce an InputRouter module. Does not change functionality, but s…
Mar 12, 2021
023c439
Cleanup of writing the DTC link files
Mar 14, 2021
00a8a23
Change processing order such that all steps in one sector are done an…
Mar 15, 2021
f4109cc
Interface updates for CMSSW following change to module processing order
aryd Mar 15, 2021
bd26658
Change in VMRouter to processing PS links before 2S in disks
Mar 15, 2021
c7487ed
Merge changes
Mar 15, 2021
d4d39b7
Cleanup of unused iSector variable in processs and memory modules
Mar 15, 2021
44ea72e
Fixes to make the HybridTracks_cfg.py run
aryd Mar 15, 2021
6d8b6f8
Cleanup of hardcoded numbers etc.
Mar 16, 2021
3124072
Merge branch 'DTC_merge_1130' of github.com:cms-l1tk/cmssw into DTC_m…
Mar 16, 2021
a40f339
Updates to MP to put all regions into one memory slot in the Projecti…
Mar 19, 2021
ed2269e
Fix to calculation of irinv for projections - no matches what is done…
Mar 25, 2021
271ec43
Remove now unused file paths for the old cable mapping code
Mar 26, 2021
be7420e
Correct missplaced curly bracket
Mar 30, 2021
c90b216
Fixes for the displaced tracking
Apr 2, 2021
b26fc19
Fix to avoid duplicate VMSTE name in D1 for standard configuration
Apr 3, 2021
576bda0
Address comments from Louise S.
Apr 4, 2021
de0f887
Ran scram b code-format
aryd Apr 4, 2021
2a823e0
Address comments from Louise S.
Apr 4, 2021
64cd602
Addressing more comments from Louise S.
Apr 5, 2021
cc9e791
More fixes to comments
Apr 5, 2021
e164c32
Make running hybrid default (not displaced)
aryd Apr 5, 2021
0c972b5
restore buildfile
skinnari Apr 6, 2021
35928d1
Add DTC link config to Settings.h
Apr 8, 2021
e8618ed
Merge branch 'DTC_merge_1130' of github.com:cms-l1tk/cmssw into DTC_m…
Apr 8, 2021
adcfecf
Changes to suppress warning in MatchCalculator when running displaced…
Apr 9, 2021
d51d818
Fix typo introduced in code cleanup for MatchProcessor
Apr 10, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions L1Trigger/TrackFindingTracklet/interface/AllInnerStubsMemory.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
#ifndef L1Trigger_TrackFindingTracklet_interface_AllInnerStubsMemory_h
#define L1Trigger_TrackFindingTracklet_interface_AllInnerStubsMemory_h

#include "L1Trigger/TrackFindingTracklet/interface/MemoryBase.h"

#include <utility>
#include <string>
#include <vector>

namespace trklet {

class Settings;
class Stub;
class L1TStub;

class AllInnerStubsMemory : public MemoryBase {
public:
AllInnerStubsMemory(std::string name, Settings const& settings);

~AllInnerStubsMemory() override = default;

void addStub(const Stub* stub) { stubs_.push_back(stub); }

unsigned int nStubs() const { return stubs_.size(); }

const Stub* getStub(unsigned int i) const { return stubs_[i]; }

void clean() override { stubs_.clear(); }

void writeStubs(bool first, unsigned int iSector);

private:
std::vector<const Stub*> stubs_;
};

}; // namespace trklet
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace trklet {

class AllProjectionsMemory : public MemoryBase {
public:
AllProjectionsMemory(std::string name, Settings const& settings, unsigned int iSector);
AllProjectionsMemory(std::string name, Settings const& settings);

~AllProjectionsMemory() override = default;

Expand All @@ -25,7 +25,7 @@ namespace trklet {

void clean() override { tracklets_.clear(); }

void writeAP(bool first);
void writeAP(bool first, unsigned int iSector);

private:
std::vector<Tracklet*> tracklets_;
Expand Down
4 changes: 2 additions & 2 deletions L1Trigger/TrackFindingTracklet/interface/AllStubsMemory.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace trklet {

class AllStubsMemory : public MemoryBase {
public:
AllStubsMemory(std::string name, Settings const& settings, unsigned int iSector);
AllStubsMemory(std::string name, Settings const& settings);

~AllStubsMemory() override = default;

Expand All @@ -27,7 +27,7 @@ namespace trklet {

void clean() override { stubs_.clear(); }

void writeStubs(bool first);
void writeStubs(bool first, unsigned int iSector);

private:
std::vector<const Stub*> stubs_;
Expand Down
39 changes: 0 additions & 39 deletions L1Trigger/TrackFindingTracklet/interface/Cabling.h

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace trklet {

class CandidateMatchMemory : public MemoryBase {
public:
CandidateMatchMemory(std::string name, Settings const& settings, unsigned int iSector);
CandidateMatchMemory(std::string name, Settings const& settings);

~CandidateMatchMemory() override = default;

Expand All @@ -28,7 +28,7 @@ namespace trklet {

void clean() override { matches_.clear(); }

void writeCM(bool first);
void writeCM(bool first, unsigned int iSector);

private:
std::vector<std::pair<std::pair<Tracklet*, int>, const Stub*> > matches_;
Expand Down
10 changes: 10 additions & 0 deletions L1Trigger/TrackFindingTracklet/interface/CircularBuffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ namespace trklet {
//Almost full if writer ptr incremented by 1 or 2 is same as read ptr
bool almostfull() const { return (((wptr_ + 1) % size_) == rptr_) || (((wptr_ + 2) % size_) == rptr_); }

//Almost full if writer ptr incremented by 1 or 2 is same as read ptr
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment for "nearfull" is identical to that of "almostfull" - can they be made more meaningful to distinguish?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed comment.

bool nearfull() const {
return (((wptr_ + 1) % size_) == rptr_) || (((wptr_ + 2) % size_) == rptr_) || (((wptr_ + 3) % size_) == rptr_);
}

//Empty buffer is write ptr is same as read ptr
bool empty() const { return wptr_ == rptr_; }

Expand All @@ -47,8 +52,13 @@ namespace trklet {
assert(!full());
buffer_[wptr_++] = element;
wptr_ = wptr_ % size_;
assert(wptr_ != rptr_);
}

unsigned int rptr() const { return rptr_; }

unsigned int wptr() const { return wptr_; }

private:
std::vector<T> buffer_;

Expand Down
4 changes: 2 additions & 2 deletions L1Trigger/TrackFindingTracklet/interface/CleanTrackMemory.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace trklet {

class CleanTrackMemory : public MemoryBase {
public:
CleanTrackMemory(std::string name, Settings const& settings, unsigned int iSector, double phimin, double phimax);
CleanTrackMemory(std::string name, Settings const& settings, double phimin, double phimax);

~CleanTrackMemory() override = default;

Expand All @@ -22,7 +22,7 @@ namespace trklet {

void clean() override { tracks_.clear(); }

void writeCT(bool first);
void writeCT(bool first, unsigned int iSector);

private:
double phimin_;
Expand Down
46 changes: 0 additions & 46 deletions L1Trigger/TrackFindingTracklet/interface/DTC.h

This file was deleted.

34 changes: 0 additions & 34 deletions L1Trigger/TrackFindingTracklet/interface/DTCLink.h

This file was deleted.

38 changes: 38 additions & 0 deletions L1Trigger/TrackFindingTracklet/interface/DTCLinkMemory.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// This class holds a list of stubs for an DTC link.
// This modules 'owns' the pointers to the stubs. All subsequent modules that handles stubs uses a pointer to the original stored here.
#ifndef L1Trigger_TrackFindingTracklet_interface_DTCLinkMemory_h
#define L1Trigger_TrackFindingTracklet_interface_DTCLinkMemory_h

#include "L1Trigger/TrackFindingTracklet/interface/MemoryBase.h"

#include <vector>

namespace trklet {

class Settings;
class Globals;
class Stub;
class L1TStub;

class DTCLinkMemory : public MemoryBase {
public:
DTCLinkMemory(std::string name, Settings const& settings, double, double);

~DTCLinkMemory() override = default;

void addStub(const L1TStub& al1stub, const Stub& stub);

unsigned int nStubs() const { return stubs_.size(); }

Stub* getStub(unsigned int i) { return stubs_[i]; }

void writeStubs(bool first, unsigned int iSector);

void clean() override;

private:
std::vector<Stub*> stubs_;
};

}; // namespace trklet
#endif
Loading