All-combined extended wiring #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you've changed the contents of TrackFindingTracklet/data/ , please make of PR to https://github.com/cms-data/L1Trigger-TrackFindingTracklet , specifying in the PR description that it should be merged into the same release of CMSSW as my PR of behalf of the L1Trk group cms-sw#45974 . I will add your code to the latter PR after this PR is merged. |
tomalin
reviewed
Sep 27, 2024
tomalin
reviewed
Sep 27, 2024
tomalin
reviewed
Sep 27, 2024
|
This looks ready to merge, aside from my few comments above. |
tomalin
reviewed
Oct 9, 2024
aehart
force-pushed
the
new_displaced_wiring
branch
from
defea85
to
88b7c69
Compare
tomalin
approved these changes
Oct 10, 2024
tomalin
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Initial commit * Separated ivmte and bins, but not correct yet * Allow combined_ to be set for extended tracking. * Logic for bins updated * Revert lutwidthtab_ and use lutwidthtabextended_ for extended tracking. * Set ivmte to zero by default and revert change to old VMRouter. * Updated assert. * Initialize LUTs from VMRouter. * Use LUT values from VMRouter for triplet seeds. * Added stubposition and made vmstubmem a vector of vectors. * Added a combined flag to addVMStub. * Use stubposition to get lutwidth. * Skip disk 2S stubs only for pair seeds. * Added some comments. * Added assert on melutOld. * Initialize in same order as declared in header file. * Code format. * Added method to return nbits_. * Removed magic numbers. * Added comments. * Use new wiring with all combined modules. * Temporarily added data directory from here: https://github.com/aehart/L1Trigger-TrackFindingTracklet/tree/new_extended_wiring --------- Co-authored-by: Jannicke Pearkes <jannicke.pearkes@cern.ch>
cgsavard
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Initial commit * Separated ivmte and bins, but not correct yet * Allow combined_ to be set for extended tracking. * Logic for bins updated * Revert lutwidthtab_ and use lutwidthtabextended_ for extended tracking. * Set ivmte to zero by default and revert change to old VMRouter. * Updated assert. * Initialize LUTs from VMRouter. * Use LUT values from VMRouter for triplet seeds. * Added stubposition and made vmstubmem a vector of vectors. * Added a combined flag to addVMStub. * Use stubposition to get lutwidth. * Skip disk 2S stubs only for pair seeds. * Added some comments. * Added assert on melutOld. * Initialize in same order as declared in header file. * Code format. * Added method to return nbits_. * Removed magic numbers. * Added comments. * Use new wiring with all combined modules. * Temporarily added data directory from here: https://github.com/aehart/L1Trigger-TrackFindingTracklet/tree/new_extended_wiring --------- Co-authored-by: Jannicke Pearkes <jannicke.pearkes@cern.ch>
cgsavard
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Initial commit * Separated ivmte and bins, but not correct yet * Allow combined_ to be set for extended tracking. * Logic for bins updated * Revert lutwidthtab_ and use lutwidthtabextended_ for extended tracking. * Set ivmte to zero by default and revert change to old VMRouter. * Updated assert. * Initialize LUTs from VMRouter. * Use LUT values from VMRouter for triplet seeds. * Added stubposition and made vmstubmem a vector of vectors. * Added a combined flag to addVMStub. * Use stubposition to get lutwidth. * Skip disk 2S stubs only for pair seeds. * Added some comments. * Added assert on melutOld. * Initialize in same order as declared in header file. * Code format. * Added method to return nbits_. * Removed magic numbers. * Added comments. * Use new wiring with all combined modules. * Temporarily added data directory from here: https://github.com/aehart/L1Trigger-TrackFindingTracklet/tree/new_extended_wiring --------- Co-authored-by: Jannicke Pearkes <jannicke.pearkes@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR includes a wiring for the extended project that consistently uses combined modules, so that we are able to remove the old non-combined modules. There are various associated changes in the C++, especially in the VMRouterCM, so that the new wiring can be used while maintaining our tracking efficiency. Essentially, the VMRouterCM should have nearly identical behavior as the old VMRouter in the case of the triplet seeds. We can revert most of these changes in the near future, as the TrackletProcessorDisplaced is gradually updated and made to be compatible with the expected output from the VMRouterCM.
PR validation:
Further details and results with the new wiring can be found in the following presentations:
https://indico.cern.ch/event/1418952/#3-displaced-tracking-update
https://indico.cern.ch/event/1449863/#2-displaced-tracking-update