Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 tk dev 12 0 0 pre4 hph after rebase #115

Closed
wants to merge 6 commits into from

Conversation

Jingyan95
Copy link

@Jingyan95 Jingyan95 commented Nov 18, 2021

This is the same as the closed PR #96 , but after rebasing to test CI. All comments on this PR are in #96 , so these should be addressed before we merge.

Will make new commits to update PR tomorrow.

@Jingyan95 Jingyan95 marked this pull request as draft November 19, 2021 21:36
@tomalin tomalin self-requested a review November 22, 2021 16:06
@tomalin tomalin changed the title L1 tk dev 12 0 0 pre4 hph L1 tk dev 12 0 0 pre4 hph after rebase Dec 16, 2021
@tomalin tomalin requested review from skinnari and removed request for tomalin February 6, 2022 00:40
@tomalin
Copy link
Collaborator

tomalin commented Feb 6, 2022

@skinnari can you please take over reviewing this, in particular checking if the comments made in #96 have been implemented to avoid code duplication etc.? I don't have time to review both this & Thomas's PRs ...

@Jingyan95 Jingyan95 closed this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants