Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when bundling, the Solid output would include instructions for
React.createElement
:As we explored on stream, this isn't easily worked around - even when using
** @jsx **
pragmas:unjs/unbuild#325
Moreover, the plugin I found that would run during ESBuild:
https://github.com/amoutonbrady/esbuild-plugin-solid/
Has a few problems, namely that we cannot pass plugins to ESBuild inside of
unbuild
, since they're using theesbuild.transform
API and notesbuild.build
API (transforming doesn't support plugins but building does)As such, I had to get clever and:
Once this was done, we have the proper output for seemingly everything.
Solid:
React:
Vue (just as an additional dataset):