Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview PR for including external completions into Cmder #434

Merged
merged 1 commit into from
Mar 20, 2015

Conversation

vladimir-kotikov
Copy link
Contributor

It does the following:

  • Moves all Cmder's prompt handling routines to cmder.lua. Purpose - exclude collisions with existing modules and reflect the fact that it is a Cmder own items.
  • Adds external lua modules search'n'load logic
  • Adds reference to completions repo to sources.json

@MartiUK
Copy link
Member

MartiUK commented Mar 20, 2015

Have you run a build using build.ps1, and does it extract the file fine?

@vladimir-kotikov
Copy link
Contributor Author

Yep. Just tried again and it works.
Note that im planning to push some minor stuff to my repo and then release a 0.1.0 version so you probably would need to change a link to archive before release.

@MartiUK
Copy link
Member

MartiUK commented Mar 20, 2015

@vladimir-kotikov just commit your changes into your dev branch and let me know when it's ready to be pulled in.

* Adds package to sources.json
* Merges all cmder's lua modules into one -> cmder.lua to exclude future conflicts
* Adds external modules loading logic
@vladimir-kotikov
Copy link
Contributor Author

@MartiUK. Looks lke i've done. I've updated a link to release archive, so all what you need it to merge this PR.

@MartiUK
Copy link
Member

MartiUK commented Mar 20, 2015

Thanks.

MartiUK added a commit that referenced this pull request Mar 20, 2015
Preview PR for including external completions into Cmder
@MartiUK MartiUK merged commit 522a758 into cmderdev:development Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants