Handle quoted paths #398
Merged
Handle quoted paths #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was annoyed at having to use short paths all the time in my aliases. It wasn't until I found a command that actually refused to work with a shortpath (running iisexpress.exe) I was determined to find a solution. It appears that the reason the quoted paths weren't working was due to the ::validate alias stuff. The for command would stumble on a quoted path, arguing that /foo was unexpected... The additions on lines 7-8 wrap the input in quotes and then strip the inner quotes. This variable is used in the for loop (instead of %*) for validating the alias. So long as the alias is valid (contains no spaces) then the existing method of appending the new alias to the aliases file works just fine because it still uses %*.
|
Accidentally sent a pull request yesterday to master. Sorry for the noob maneuver. Hopefully this PR is better. |
|
|
||
| set _temp=%_temp2: =% | ||
| :: validate alias | ||
| for /f "delims== tokens=1" %%G in ("%_x%") do set alias=%%G |
There was a problem hiding this comment.
IMHO, since %_x% usage is not needed in arguments check (line 10) then it is better to move its definition to actual usage here.
There was a problem hiding this comment.
Since the %_x% is needed in the arguments check, the declaration must remain at the top of the file.
|
👍 |
|
@mikesigs can you rebase, please? |
Conflicts: bin/alias.bat
|
@Stanzilla Done and done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed at having to use short paths all the time in my aliases. It wasn't until I found a command that actually refused to work with a shortpath (running iisexpress.exe) I was determined to find a solution.
Quoted paths weren't working whenever the script used "%*". You'd get an error like "File was unexpected at this time."
The additions on lines 6-7 wrap the input in quotes and then strip the inner quotes. This variable is used in the for loop (instead of %*) for validating the alias. It's also used in the first usage check.
I also renamed a variable and indented a couple things.
The command I used as my test was:
alias runapi=runas /netonly /user:domain\user "c:\Program Files (x86)\IIS Express\iisexpress.exe /site :WebAppName /trace:i"