Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes small Powershell' loader issues #273

Merged
merged 2 commits into from
Mar 18, 2015
Merged

Fixes small Powershell' loader issues #273

merged 2 commits into from
Mar 18, 2015

Conversation

LeoColomb
Copy link
Contributor

No description provided.

@LeoColomb
Copy link
Contributor Author

So cool & beautiful with both posh-git and PSReadLine installed! (Run Install-Module [Name])


capture

@LeoColomb
Copy link
Contributor Author

I've done 2 hours checks for everything (ConEmu features, Cmder features (opening situations, shortcuts, ...)), and I haven't any issues to report about this integration.

@MartiUK
Copy link
Member

MartiUK commented Sep 17, 2014

I'll try to have a test of it tonight.

@LeoColomb
Copy link
Contributor Author

Any news here?

Get-ChildItem -Directory | `
Foreach-Object{
Import-Module .\PsGet\PsGet
Get-ChildItem -Exclude "PsGet" -Directory -Name | `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's bad practice to use the back tick to escape the carriage return, any white-space after the back tick will suddenly break the return and it's hard to tell.

The pipe can escape line endings anyway so the back tick is also redundant anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* Fix modules order required
* Add newline before prompt
* Fix color name
@thor
Copy link

thor commented Mar 8, 2015

Seems like there's not really anything anyone is waiting for, is there?

@LeoColomb
Copy link
Contributor Author

@thor What do you mean? 😄

MartiUK added a commit that referenced this pull request Mar 18, 2015
Fixes small Powershell' loader issues
@MartiUK MartiUK merged commit 021263d into cmderdev:development Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants