Fix alias.bat handling "user-aliases.cmd" with spaces #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the alias command when user-aliases.cmd is located in a path with spaces (like when Cmder is installed into the program-files directory). I've also made the alphabetical case of the ALIASES variable consistent.
MartiUK
reviewed
Nov 1, 2017
bin/alias.bat
Outdated
| if "%aliases%" == "" ( | ||
| set ALIASES=%CMDER_ROOT%\config\user-aliases.cmd | ||
| if "%ALIASES%" == "" ( | ||
| set aliases="%CMDER_ROOT%\config\user-aliases.cmd" |
There was a problem hiding this comment.
Is this supposed to be lowercase?
There was a problem hiding this comment.
I can change it to either be upper case or lower case - Command prompt variables are case insensitive.
The original problem was that half the file was using an upper case variant of the name, while the rest was using a lower case variant.
There was a problem hiding this comment.
well imo it should be consistent if you change it now, change it everywhere, no?
Stanzilla
requested changes
Nov 23, 2017
bin/alias.bat
Outdated
| if "%aliases%" == "" ( | ||
| set ALIASES=%CMDER_ROOT%\config\user-aliases.cmd | ||
| if "%ALIASES%" == "" ( | ||
| set aliases="%CMDER_ROOT%\config\user-aliases.cmd" |
daxgames
pushed a commit
to daxgames/cmder
that referenced
this pull request
Mar 7, 2018
* Fix alias.bat handling "user-aliases.cmd" with spaces This fixes the alias command when user-aliases.cmd is located in a path with spaces (like when Cmder is installed into the program-files directory). I've also made the alphabetical case of the ALIASES variable consistent. * address review comments
daxgames
pushed a commit
to daxgames/cmder
that referenced
this pull request
Mar 7, 2018
* Fix alias.bat handling "user-aliases.cmd" with spaces This fixes the alias command when user-aliases.cmd is located in a path with spaces (like when Cmder is installed into the program-files directory). I've also made the alphabetical case of the ALIASES variable consistent. * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the alias command when user-aliases.cmd is located in a path with spaces (like when Cmder is installed into the program-files directory).
I've also made the alphabetical case of the ALIASES variable consistent.