The rest of the roadmap features! #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also created a new function `escape_all` to fix the issue of not being able to escape a collection of Into<String> options for the logical functions. This problem caused a panic in the stop words cookbook section because if the result of `or()` was wrapped in square brackets, the hyphens in the text pulled from the stop words library would be interpreted as ranges.
|
This is AMAZING, @PacificBird! Thank you for this huge PR. The strings can become amazingly jank so some refactoring would be very welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains documented and tested versions of all the remaining roadmap features left to implement. As noted in the comments of
xorandsubtract, I think our simple type system is holding us back currently. As of right now HumanRegex is essentially just a readable string templating system, which is fine, but it requires some jank to make sure the user cannot input invalid Rust RegEx, which is a shame. Now that these roadmap features are done, I think I could take on a project of refactoring the library to work with some new types implementing Into<HumanRegex> and some traits to go along with them. This way we could do really cool things like have a unified negation function. This would also allow us to clean up our generic system as mentioned here. Let me know what you think of this idea.