Support Camera View in Simulator #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksylvest
changed the title
ksylvest
force-pushed
the
ksylvest/support-camera-view-in-simulator
branch
2 times, most recently
from
fc7d94d to
8177847
Compare
ksylvest
force-pushed
the
ksylvest/support-camera-view-in-simulator
branch
from
8177847 to
a12be14
Compare
ksylvest
changed the title
litso
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our automated test suite runs often opens cameras. This runs in the simulator, and isn't properly supported. It causes issues for a few reasons:
This fixes by making our simulator capture fake (cyan) square image every time.
Demo
Screen.Recording.2022-03-30.at.7.00.47.PM.mov