Skip to content

Commit

Permalink
Merge pull request #15 from clue-labs/legacy
Browse files Browse the repository at this point in the history
Revert "Updating Stream dependency fixes legacy PHP < 5.4 issues"
  • Loading branch information
clue authored Aug 19, 2017
2 parents b96af83 + ed9996b commit f950d22
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ These inconsistencies exist in the underlying PHP engines and there's little we
* PHP 7 only: Compressing an empty string does not emit any data (not a valid compression stream)
* HHVM only: does not currently support the GZIP and ZLIB format at all (and does not raise an error)
* HHVM only: The [`zlib.deflate` filter function](https://github.com/facebook/hhvm/blob/fee8ae39ce395c7b9b8910dfde6f22a7745aea83/hphp/system/php/stream/default-filters.php#L77) buffers the whole string. This means that compressing a stream of 100 MB actually stores the whole string in memory before invoking the underlying compression algorithm.
* PHP 5.3 only: Tends to SEGFAULT occasionally on shutdown?

Our test suite contains several test cases that exhibit these issues.
If you feel some test case is missing or outdated, we're happy to accept PRs! :)
Expand Down

0 comments on commit f950d22

Please sign in to comment.