Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CHANGELOG.md #53

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix typo in CHANGELOG.md #53

merged 1 commit into from
Nov 23, 2023

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Nov 13, 2023

This pull request fixes a typo with the help of https://github.com/szepeviktor/typos-on-you.

Builds on top of #43, #39, #37, #21 and #19.

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 👍

Seems like the test runs for legacy HHVM won't run, seems like we have to update our test suite as I did in clue/reactphp-csv#33.

Is this something you can look into?

@SimonFrings SimonFrings added the documentation Improvements or additions to documentation label Nov 14, 2023
@SimonFrings SimonFrings added this to the v1.9.0 milestone Nov 14, 2023
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit 6e9475c into clue:1.x Nov 23, 2023
14 checks passed
@yadaiio yadaiio mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants