Composer path with spaces bugfix #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably it works on linux environment, but on windows, if composer's executable file located by path that includes the spaces, command can't be executed. So this small fix should will prevent this error.
|
In my case its stops with this type of error.
|
Explict bug fix in 871bc77 commit
|
Thank you for nice lib. I've tried to solve the problem quickly as i can and only for my environment. So i am not suprised about failing the tests. Maybe you find more elegant way to fix it. |
|
@dnquinn Thank you, this has now been fixed via #128 (and #129) and I'll make sure to get this shipped asap! I hope this helps! 👍 If so, consider supporting this project, for example by becoming a sponsor ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably it works on linux environment, but on windows, if composer's executable file located by path that includes the spaces, command can't be executed. So this small fix should will prevent this error.