Increase sleep time to cover test case for inaccurate clocks #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
force-pushed
the
inaccurate_clocks
branch
from
f0c6b91 to
bf6876d
Compare
SimonFrings
changed the title
|
@SimonFrings Good catch, thanks for the update! Looks like this has been in place since #49 and has indeed repeatedly caused some false negatives when testing on Windows in the past. |
clue
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over time we recognized failing tests because of an incorrect time measurement in our tests which mostly occurred when running our test suite under windows. Last seen here: https://github.com/clue/framework-x/actions/runs/3741602828/jobs/6351445435
I raised the sleep-time inside the responsible test to avoid any future tests failing because of inaccurate clocks.