Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor contract verification to get constructor arguments from contracts #740

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Apr 16, 2024

This PR allows contract verifications to get constructor arguments from contracts if the arguments are not found in the deployed-contracts.json file.

When new rounds are deployed from a Gnosis Safe wallet, the deployed-contracts.json file will not be generated (as it's generated when deploying from the hardhat command line), users can still verify the contracts by passing the --clrfund flag.

@yuetloo yuetloo self-assigned this Apr 16, 2024
@yuetloo yuetloo requested a review from auryn-macmillan April 16, 2024 21:23
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for clrfund-staging ready!

Name Link
🔨 Latest commit c0ca064
🔍 Latest deploy log https://app.netlify.com/sites/clrfund-staging/deploys/6621cc4e6591d200088c1559
😎 Deploy Preview https://deploy-preview-740--clrfund-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yuetloo yuetloo merged commit 0822503 into develop Apr 19, 2024
6 checks passed
@yuetloo yuetloo deleted the refactor/verify-all branch April 19, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants