Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tally hardhat script #738

Merged
merged 13 commits into from
Apr 18, 2024
Merged

Refactor tally hardhat script #738

merged 13 commits into from
Apr 18, 2024

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Apr 3, 2024

Refactor the tally script to simplify rerun on error. Rerun no longer need additional arguments. Also break the tally script into the following smaller scripts to simplify re-running the scripts.

  • gen-proofs
  • prove-on-chain
  • publish-tally-results

@yuetloo yuetloo self-assigned this Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for clrfund-staging ready!

Name Link
🔨 Latest commit 88f8898
🔍 Latest deploy log https://app.netlify.com/sites/clrfund-staging/deploys/6610b450b079b40008f95009
😎 Deploy Preview https://deploy-preview-738--clrfund-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuetloo yuetloo requested a review from auryn-macmillan April 17, 2024 17:13
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yuetloo yuetloo merged commit 20adb18 into develop Apr 18, 2024
7 checks passed
@yuetloo yuetloo deleted the feat/tally-subtask branch April 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants