Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incremental deployment and manual nonce management options #728

Merged
merged 19 commits into from
Mar 21, 2024

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Mar 15, 2024

The incremental contract deployment feature is useful especially in the production environment to allow restart from a failed deployment.

The manual nonce management is useful for some node (e.g. optimism Sepolia public node) where the node sometimes returns older nonce. This option will allow the deployment script to manually increment the nonce instead of querying the node for the next nonce value. This allows deployment to run successfully.

This PR also added the option to verify contracts after deployment.

For example, the following command to deploy a new ClrFund instance with the options to verify contract after deployment and manually set the nonce in each deployment transaction and only deploy contracts that haven't deployed in previous run.

yarn hardhat new-clrfund --network optimism-sepolia --increment --verify --manage-nonce

After successful deployment, the contract addresses will be recorded in the file contracts/deployed-contracts.json
The new deployment script will also need configuration in the contracts/deploy-config.json file

@yuetloo yuetloo self-assigned this Mar 15, 2024
@yuetloo yuetloo changed the base branch from develop to feat/maci-v1 March 15, 2024 02:41
@yuetloo yuetloo marked this pull request as draft March 15, 2024 02:42
@yuetloo yuetloo changed the base branch from feat/maci-v1 to develop March 20, 2024 21:13
@yuetloo yuetloo changed the title Add options to allow incremental contract deployment and manual nonce management Add incremental deployment and manual nonce management options Mar 20, 2024
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for clrfund-staging ready!

Name Link
🔨 Latest commit 24d7117
🔍 Latest deploy log https://app.netlify.com/sites/clrfund-staging/deploys/65fc60d82c70e600082067dd
😎 Deploy Preview https://deploy-preview-728--clrfund-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuetloo yuetloo requested a review from auryn-macmillan March 21, 2024 04:39
@yuetloo yuetloo marked this pull request as ready for review March 21, 2024 04:40
@yuetloo yuetloo merged commit 853ecc1 into develop Mar 21, 2024
6 checks passed
@yuetloo yuetloo deleted the feat/maci-v1-deploy branch March 21, 2024 16:42
@yuetloo yuetloo linked an issue Mar 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor contract deployment/execution scripts
2 participants