Add snapshot user registry #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @dev Reject user | ||
| * @param _user user account address | ||
| */ | ||
| function rejectUser(address _user) external onlyOwner { |
There was a problem hiding this comment.
What are the purposes of rejectUser and resetUser?
How do we envision them being used in practice, @yuetloo?
There was a problem hiding this comment.
I was thinking to let the coordinator reject sybil accounts. But, you're right that in practice, it's too late as once the user is added, they would've contributed and in the round.
| } | ||
| }) | ||
|
|
||
| describe('Add user', function () { |
There was a problem hiding this comment.
Would be good to add tests for users that currently meet the requirements, but did not at the snapshot block, and for users who do not currently meet the requirements, but did at the snapshot block.
|
Closing this PR as changes have been merged to #711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This user registry will add users who can be verified by the proof of token ownership at a snapshot block.