Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing round error #664

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Fix missing round error #664

merged 2 commits into from
Jun 2, 2023

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Jun 1, 2023

When a funding round has not been deployed, the prompt for user signature will give error because of missing round information. Do not prompt for signature if there's no round.

@yuetloo yuetloo self-assigned this Jun 1, 2023
@yuetloo yuetloo requested a review from auryn-macmillan June 1, 2023 23:48
@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for clrfund-develop ready!

Name Link
🔨 Latest commit 3415a01
🔍 Latest deploy log https://app.netlify.com/sites/clrfund-develop/deploys/64792e3852f12400082bbd5a
😎 Deploy Preview https://deploy-preview-664--clrfund-develop.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yuetloo yuetloo merged commit e2ae2e0 into develop Jun 2, 2023
@yuetloo yuetloo deleted the fix/missing-round-error branch June 2, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants