Skip to content

Commit

Permalink
Refactor modal and not allow close on click or esc.
Browse files Browse the repository at this point in the history
  • Loading branch information
yuetloo committed Apr 17, 2024
1 parent 7e0c45f commit 6dfaeb4
Show file tree
Hide file tree
Showing 13 changed files with 30 additions and 35 deletions.
1 change: 1 addition & 0 deletions vue-app/src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,7 @@ summary:focus {
padding: $modal-space;
text-align: center;
box-shadow: var(--box-shadow);
border: 2px solid rgba(115, 117, 166, 0.3);
width: 400px;
.loader {
margin: $modal-space auto;
Expand Down
1 change: 1 addition & 0 deletions vue-app/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ declare module '@vue/runtime-core' {
AddToCartButton: typeof import('./components/AddToCartButton.vue')['default']
BackLink: typeof import('./components/BackLink.vue')['default']
BalanceItem: typeof import('./components/BalanceItem.vue')['default']
BaseModal: typeof import('./components/BaseModal.vue')['default']
Breadcrumbs: typeof import('./components/Breadcrumbs.vue')['default']
BrightIdWidget: typeof import('./components/BrightIdWidget.vue')['default']
CallToActionCard: typeof import('./components/CallToActionCard.vue')['default']
Expand Down
9 changes: 9 additions & 0 deletions vue-app/src/components/BaseModal.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<template>
<vue-final-modal class="modal-container" :click-to-close="false" :esc-to-close="false">
<slot></slot>
</vue-final-modal>
</template>

<script setup>
import { VueFinalModal } from 'vue-final-modal'
</script>
2 changes: 1 addition & 1 deletion vue-app/src/components/Cart.vue
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ function submitCart(event: any) {
}
const canWithdrawContribution = computed(
() => currentRound.value?.status === RoundStatus.Cancelled && !contribution.value,
() => currentRound.value?.status === RoundStatus.Cancelled && contribution.value > 0n,
)
const showCollapseCart = computed(() => route.name !== 'cart')
Expand Down
6 changes: 2 additions & 4 deletions vue-app/src/components/ClaimModal.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<vue-final-modal class="modal-container" background="interactive">
<base-modal>
<div class="modal-body">
<div v-if="step === 1">
<h2>{{ $t('claimModal.h2_1') }}</h2>
Expand All @@ -24,7 +24,7 @@
</button>
</div>
</div>
</vue-final-modal>
</base-modal>
</template>

<script setup lang="ts">
Expand All @@ -33,8 +33,6 @@ import { Contract } from 'ethers'
import { FundingRound } from '@/api/abi'
import type { Project } from '@/api/projects'
import Transaction from '@/components/Transaction.vue'
// @ts-ignore
import { VueFinalModal } from 'vue-final-modal'
import { formatAmount as _formatAmount } from '@/utils/amounts'
import { waitForTransaction, getEventArg } from '@/utils/contracts'
import { getRecipientClaimData } from '@clrfund/common'
Expand Down
6 changes: 2 additions & 4 deletions vue-app/src/components/ContributionModal.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<vue-final-modal class="modal-container" background="interactive">
<base-modal>
<div class="modal-body">
<div v-if="step === 0">
<h2>
Expand Down Expand Up @@ -116,7 +116,7 @@
></transaction>
</div>
</div>
</vue-final-modal>
</base-modal>
</template>

<script setup lang="ts">
Expand All @@ -128,8 +128,6 @@ import Transaction from '@/components/Transaction.vue'
import { formatAmount } from '@/utils/amounts'
import { waitForTransaction, getEventArg, getPollContract } from '@/utils/contracts'
import ProgressBar from '@/components/ProgressBar.vue'
// @ts-ignore
import { VueFinalModal } from 'vue-final-modal'
import { FundingRound, ERC20, MACI } from '@/api/abi'
import { useAppStore, useUserStore } from '@/stores'
import { storeToRefs } from 'pinia'
Expand Down
6 changes: 2 additions & 4 deletions vue-app/src/components/ErrorModal.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<vue-final-modal class="modal-container" background="interactive">
<base-modal>
<div class="modal-body">
<div v-if="errorMessage">
<div class="error">{{ errorMessage }}</div>
Expand All @@ -8,12 +8,10 @@
</button>
</div>
</div>
</vue-final-modal>
</base-modal>
</template>

<script setup lang="ts">
// @ts-ignore
import { VueFinalModal } from 'vue-final-modal'
interface Props {
errorMessage: string
}
Expand Down
5 changes: 2 additions & 3 deletions vue-app/src/components/MatchingFundsModal.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<vue-final-modal class="modal-container" background="interactive">
<base-modal>
<div class="modal-body">
<div v-if="step === 1">
<h3>{{ $t('matchingFundsModal.title', { nativeTokenSymbol }) }}</h3>
Expand Down Expand Up @@ -57,7 +57,7 @@
<button class="btn-primary" @click="$emit('close')">{{ $t('matchingFundsModal.button3') }}</button>
</div>
</div>
</vue-final-modal>
</base-modal>
</template>

<script setup lang="ts">
Expand All @@ -72,7 +72,6 @@ import { formatUnits } from 'ethers'
import { ERC20 } from '@/api/abi'
import { clrFundContract } from '@/api/core'
import { VueFinalModal } from 'vue-final-modal'
import { useAppStore, useUserStore } from '@/stores'
const appStore = useAppStore()
Expand Down
6 changes: 2 additions & 4 deletions vue-app/src/components/ReallocationModal.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<vue-final-modal class="modal-container" background="interactive">
<base-modal>
<div class="modal-body">
<div v-if="step === 1">
<h3>{{ $t('reallocationModal.h3') }}</h3>
Expand All @@ -17,16 +17,14 @@
></transaction>
</div>
</div>
</vue-final-modal>
</base-modal>
</template>

<script lang="ts" setup>
import { Contract } from 'ethers'
import type { PubKey, Message } from '@clrfund/common'
import Transaction from '@/components/Transaction.vue'
import { waitForTransaction, getPollContract } from '@/utils/contracts'
import { createMessage } from '@clrfund/common'
import { VueFinalModal } from 'vue-final-modal'
import { useAppStore, useUserStore } from '@/stores'
import { useRouter } from 'vue-router'
Expand Down
6 changes: 2 additions & 4 deletions vue-app/src/components/SignatureModal.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<vue-final-modal class="modal-container" background="interactive">
<base-modal>
<div class="modal-body">
<div v-if="requestingSignature" class="loading">
<loader />
Expand All @@ -12,12 +12,10 @@
</button>
</div>
</div>
</vue-final-modal>
</base-modal>
</template>

<script setup lang="ts">
// @ts-ignore
import { VueFinalModal } from 'vue-final-modal'
import { useUserStore } from '@/stores'
const userStore = useUserStore()
Expand Down
6 changes: 2 additions & 4 deletions vue-app/src/components/TransactionModal.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<vue-final-modal class="modal-container" background="interactive">
<base-modal>
<div class="modal-body">
<transaction
:hash="txHash"
Expand All @@ -17,13 +17,11 @@
{{ $t('transactionModal.button1') }}
</button>
</div>
</vue-final-modal>
</base-modal>
</template>

<script setup lang="ts">
import type { TransactionResponse } from 'ethers'
// @ts-ignore
import { VueFinalModal } from 'vue-final-modal'
import Transaction from '@/components/Transaction.vue'
import { waitForTransaction } from '@/utils/contracts'
Expand Down
5 changes: 2 additions & 3 deletions vue-app/src/components/WalletModal.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<vue-final-modal class="modal-container" background="interactive">
<base-modal>
<div v-if="connectingWallet" class="modal-body loading">
<loader />
<p>{{ $t('walletModal.p1') }}</p>
Expand All @@ -25,13 +25,12 @@
</button>
<div v-if="error" class="error">{{ error }}</div>
</div>
</vue-final-modal>
</base-modal>
</template>

<script setup lang="ts">
import Loader from '@/components/Loader.vue'
import { useWalletStore, type WalletProvider } from '@/stores'
import { VueFinalModal } from 'vue-final-modal'
const error = ref('')
const connectingWallet = ref(false)
Expand Down
6 changes: 2 additions & 4 deletions vue-app/src/components/WithdrawalModal.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<vue-final-modal class="modal-container" background="interactive">
<base-modal>
<div class="modal-body">
<div v-if="step === 1">
<h3>{{ $t('withdrawalModal.h3_1') }}</h3>
Expand All @@ -18,13 +18,11 @@
</button>
</div>
</div>
</vue-final-modal>
</base-modal>
</template>

<script setup lang="ts">
import { onMounted, ref } from 'vue'
// @ts-ignore
import { VueFinalModal } from 'vue-final-modal'
import { withdrawContribution } from '@/api/contributions'
import Transaction from '@/components/Transaction.vue'
import { waitForTransaction } from '@/utils/contracts'
Expand Down

0 comments on commit 6dfaeb4

Please sign in to comment.