Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change model_kwargs argument to encoder_outputs to support transformers>=4.22.1 #56

Merged

Conversation

SamSamhuns
Copy link
Contributor

Newer versions of the transformer library do a _validate_model_kwargs call inside transformers/generation_utils.py that check if the model arguments match between the decoder forward and _prepare_input_ids_for_generation function calls.

@gwkrsrch
Copy link
Collaborator

Hi @SamSamhuns , deeply thanks for this PR! Is this change compatible with transformers<4.22.1 ?

@SamSamhuns
Copy link
Contributor Author

Tested with transformers==4.22.0 from pip install "transformers>=4.11.3,<4.22.1", it works for me

@gwkrsrch gwkrsrch merged commit 5ff2b3a into clovaai:master Oct 5, 2022
@SamSamhuns SamSamhuns deleted the fix_for_new_transformers_lib_ver branch August 2, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants