Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: unify timeout error #884

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

welkeyever
Copy link
Member

@welkeyever welkeyever commented Aug 3, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

保持一致的超时错误返回

(Optional) More detail description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@welkeyever welkeyever requested review from a team as code owners August 3, 2023 03:22
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.03% ⚠️

Comparison is base (f4cde92) 79.86% compared to head (d19c117) 79.83%.
Report is 1 commits behind head on develop.

❗ Current head d19c117 differs from pull request most recent head 43115be. Consider uploading reports for the commit 43115be to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #884      +/-   ##
===========================================
- Coverage    79.86%   79.83%   -0.03%     
===========================================
  Files           97       97              
  Lines         9587     9598      +11     
===========================================
+ Hits          7657     7663       +6     
- Misses        1430     1435       +5     
  Partials       500      500              
Files Changed Coverage Δ
pkg/network/netpoll/connection.go 70.21% <0.00%> (-3.13%) ⬇️
pkg/network/standard/connection.go 81.13% <0.00%> (-0.49%) ⬇️
pkg/common/test/mock/network.go 91.97% <33.33%> (-1.15%) ⬇️
pkg/protocol/http1/client.go 73.42% <33.33%> (+0.14%) ⬆️
pkg/protocol/http1/ext/common.go 70.12% <100.00%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@welkeyever welkeyever merged commit fc36f6f into develop Aug 3, 2023
@welkeyever welkeyever deleted the optimize/unify_client_error_return branch August 3, 2023 08:29
@welkeyever welkeyever restored the optimize/unify_client_error_return branch August 18, 2023 12:11
@welkeyever welkeyever deleted the optimize/unify_client_error_return branch September 7, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants