Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: modify judgment conditions when use retry and err = nil #860

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Jul 17, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

  • 修改使用 retry 并且 err = nil 时的判断条件

zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@li-jin-gou li-jin-gou requested review from a team as code owners July 17, 2023 13:52
@li-jin-gou li-jin-gou changed the title 【WIP】optimize: modify judgment conditions when err = nil 【WIP】optimize: modify judgment conditions when use retry and err = nil Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2bd70be) 75.87% compared to head (e256bde) 75.87%.

❗ Current head e256bde differs from pull request most recent head 8688557. Consider uploading reports for the commit 8688557 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #860   +/-   ##
========================================
  Coverage    75.87%   75.87%           
========================================
  Files           97       97           
  Lines         9512     9512           
========================================
  Hits          7217     7217           
  Misses        1846     1846           
  Partials       449      449           
Impacted Files Coverage Δ
pkg/protocol/http1/client.go 59.59% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou li-jin-gou changed the title 【WIP】optimize: modify judgment conditions when use retry and err = nil optimize: modify judgment conditions when use retry and err = nil Jul 18, 2023
@li-jin-gou
Copy link
Member Author

PATL @welkeyever @FGYFFFF @wzekin

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a small risk: this change may cause the business that did not enter the custom retry logic to enter the retry logic when err == nil.

@li-jin-gou li-jin-gou merged commit 1c49d8b into cloudwego:develop Jul 18, 2023
@a631807682 a631807682 mentioned this pull request Jul 22, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants