Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hz): client snake tag name #851

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Jul 6, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

生成 client 代码支持 snake style 的注解名

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: generate client code to support snake style annotation names
zh(optional): 生成 client 代码支持 snake style 的注解名

hz client --idl=*** --snake_tag

setQueryParams(map[string]interface{}{
	"is_bool_opt":     req.GetIsBoolOpt(),
	"is_bool_req":     req.GetIsBoolReq(),
	"is_byte_opt":     req.GetIsByteOpt(),
	"is_byte_req":     req.GetIsByteReq(),
	"is_i16_opt":      req.GetIsI16Opt(),
        )

hz client --idl=***

setQueryParams(map[string]interface{}{
	"IsBoolOpt":    req.GetIsBoolOpt(),
	"IsBoolReq":    req.GetIsBoolReq(),
	"IsByteOpt":    req.GetIsByteOpt(),
	"IsByteReq":    req.GetIsByteReq(),
         )

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners July 6, 2023 08:22
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (7e4eaab) 75.77% compared to head (b9da97c) 75.74%.

❗ Current head b9da97c differs from pull request most recent head 3561a08. Consider uploading reports for the commit 3561a08 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #851      +/-   ##
===========================================
- Coverage    75.77%   75.74%   -0.04%     
===========================================
  Files           97       97              
  Lines         9515     9515              
===========================================
- Hits          7210     7207       -3     
- Misses        1855     1858       +3     
  Partials       450      450              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF merged commit 90e1ff0 into cloudwego:develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants