Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hz): add template func #847

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Jul 6, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

添加模板参数

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: add template func
zh(optional): 添加模板参数

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners July 6, 2023 06:26
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 93.54% and project coverage change: +0.07 🎉

Comparison is base (f4f193d) 75.70% compared to head (4f98240) 75.77%.

❗ Current head 4f98240 differs from pull request most recent head 4fa1269. Consider uploading reports for the commit 4fa1269 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #847      +/-   ##
===========================================
+ Coverage    75.70%   75.77%   +0.07%     
===========================================
  Files           97       97              
  Lines         9495     9515      +20     
===========================================
+ Hits          7188     7210      +22     
+ Misses        1857     1855       -2     
  Partials       450      450              
Impacted Files Coverage Δ
pkg/protocol/http1/ext/stream.go 18.98% <88.88%> (+4.60%) ⬆️
pkg/network/standard/connection.go 81.62% <95.45%> (+0.55%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF force-pushed the feat/add_template_funcs branch from f98da25 to 4fa1269 Compare July 6, 2023 06:28
@FGYFFFF FGYFFFF merged commit 37c7361 into cloudwego:develop Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants