Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hz): miss searching middleware #846

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Jul 6, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

漏掉中间件的生成

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: miss searching middleware
zh(optional): 漏掉中间件的生成
如果已有"_sub_taskMw"中间件,那么在插入 "_taskMw"的时候做了匹配,误认为已经有了该中间件

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners July 6, 2023 03:29
@FGYFFFF FGYFFFF changed the title fix: miss searching middleware fix(hz): miss searching middleware Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 93.54% and project coverage change: +0.14 🎉

Comparison is base (f4f193d) 75.70% compared to head (fde5067) 75.84%.

❗ Current head fde5067 differs from pull request most recent head 275c544. Consider uploading reports for the commit 275c544 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #846      +/-   ##
===========================================
+ Coverage    75.70%   75.84%   +0.14%     
===========================================
  Files           97       97              
  Lines         9495     9515      +20     
===========================================
+ Hits          7188     7217      +29     
+ Misses        1857     1849       -8     
+ Partials       450      449       -1     
Impacted Files Coverage Δ
pkg/protocol/http1/ext/stream.go 18.98% <88.88%> (+4.60%) ⬆️
pkg/network/standard/connection.go 81.62% <95.45%> (+0.55%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF force-pushed the fix/middleware_insert_miss branch from 353c30c to 275c544 Compare July 6, 2023 06:27
@FGYFFFF FGYFFFF enabled auto-merge (squash) July 6, 2023 06:35
@FGYFFFF FGYFFFF disabled auto-merge July 6, 2023 06:35
@FGYFFFF FGYFFFF merged commit 21c799d into cloudwego:develop Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants