Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hz): remove tag #811

Merged
merged 2 commits into from
Jul 18, 2023
Merged

feat(hz): remove tag #811

merged 2 commits into from
Jul 18, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Jun 12, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

hz 生成代码支持删除某些 tag

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: hz generates code to support removing tags
zh(optional): hz 生成代码支持删除某些 tag

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners June 12, 2023 04:31
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (2bd70be) 75.87% compared to head (84e3494) 75.76%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #811      +/-   ##
===========================================
- Coverage    75.87%   75.76%   -0.11%     
===========================================
  Files           97       97              
  Lines         9512     9512              
===========================================
- Hits          7217     7207      -10     
- Misses        1846     1855       +9     
- Partials       449      450       +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

welkeyever
welkeyever previously approved these changes Jun 16, 2023
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@welkeyever
Copy link
Member

Reminder: fill the checkboxes in pr description.

@Duslia
Copy link
Member

Duslia commented Jul 18, 2023

ci image

@FGYFFFF FGYFFFF merged commit e1d541b into develop Jul 18, 2023
@FGYFFFF FGYFFFF deleted the feat/rm_tag branch July 18, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants