-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for protocol http1 #804
Conversation
thanks💖 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #804 +/- ##
===========================================
+ Coverage 75.87% 79.84% +3.96%
===========================================
Files 97 97
Lines 9512 9534 +22
===========================================
+ Hits 7217 7612 +395
+ Misses 1846 1423 -423
- Partials 449 499 +50
☔ View full report in Codecov by Sentry. |
It seems that it's useless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! LGTM
As for the "duplicated code" you may trigger another pr for it~ |
I will create another PR for it |
@a631807682 There's a conflict that needs to be resolved. |
done |
What type of PR is this?
test
Check the PR title.
<type>(optional scope): <description>
.(Optional) Translate the PR title into Chinese.
添加 pkg/protocol/http1 单测
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: Supplement unit test for pkg/protocol/http1, coverage increased from 53.30% to 81.9%.
zh(optional): 补充 pkg/protocol/http1 的单元测试,覆盖率从 53.30% 提高到了 81.9%。
其他疑问:
zr 已经 release,并且没有别的引用 https://github.com/cloudwego/hertz/blob/develop/pkg/protocol/http1/server.go#L328-L332
这里再判断一遍是必要的吗?https://github.com/cloudwego/hertz/blob/develop/pkg/protocol/http1/server.go#L353-L356
(Optional) Which issue(s) this PR fixes:
related to #257
(Optional) The PR that updates user documentation: