Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no copy some fields at ResponseHeader and RequestHeader #796

Merged
merged 1 commit into from
May 29, 2023

Conversation

wzekin
Copy link
Contributor

@wzekin wzekin commented May 29, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

修复 ResponseHeaderRequestHeaderCopyTo 方法没有复制部分字段的问题

(Optional) More detail description for this PR(en: English/zh: Chinese).

en:

  • In ResponseHeader.CopyTo, the protocol and headerLength fields are not copied
  • In RequestHeader.CopyTo, the protocol field is not copied

zh(optional):

  • ResponseHeader.CopyTo 中, 没有复制protocolheaderLength字段
  • RequestHeader.CopyTo 中, 没有复制protocol字段

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@wzekin wzekin requested review from a team as code owners May 29, 2023 02:45
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18 🎉

Comparison is base (ca1fb0e) 75.59% compared to head (c6d3ddc) 75.78%.

❗ Current head c6d3ddc differs from pull request most recent head 3e262fa. Consider uploading reports for the commit 3e262fa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #796      +/-   ##
===========================================
+ Coverage    75.59%   75.78%   +0.18%     
===========================================
  Files           97       97              
  Lines         9477     9480       +3     
===========================================
+ Hits          7164     7184      +20     
+ Misses        1862     1846      -16     
+ Partials       451      450       -1     
Impacted Files Coverage Δ
pkg/protocol/header.go 78.08% <100.00%> (+1.16%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

welkeyever
welkeyever previously approved these changes May 29, 2023
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzekin wzekin merged commit f249cb3 into cloudwego:develop May 29, 2023
Skyenought pushed a commit to Skyenought/hertz that referenced this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants