Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hz): add more template parameters #795

Merged

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented May 26, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

添加更多模板渲染参数

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: add more parameters for template
zh(optional): 为模板添加更多渲染参数

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners May 26, 2023 09:43
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (2bd70be) 75.87% compared to head (100885b) 75.79%.

❗ Current head 100885b differs from pull request most recent head fb2abd0. Consider uploading reports for the commit fb2abd0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #795      +/-   ##
===========================================
- Coverage    75.87%   75.79%   -0.08%     
===========================================
  Files           97       97              
  Lines         9512     9512              
===========================================
- Hits          7217     7210       -7     
- Misses        1846     1852       +6     
- Partials       449      450       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF force-pushed the feat/add_more_template_parameters branch from 95fca75 to fb2abd0 Compare July 18, 2023 06:16
@FGYFFFF FGYFFFF merged commit 3ecd986 into cloudwego:develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants