Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: public ErrNoMultipartForm #785

Merged
merged 3 commits into from
May 22, 2023

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented May 18, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

  • 公开 ErrNoMultipartForm

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@li-jin-gou li-jin-gou requested review from a team as code owners May 18, 2023 07:12
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.08 ⚠️

Comparison is base (62aa1a0) 75.66% compared to head (454fe1b) 75.59%.

❗ Current head 454fe1b differs from pull request most recent head d8b992d. Consider uploading reports for the commit d8b992d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #785      +/-   ##
===========================================
- Coverage    75.66%   75.59%   -0.08%     
===========================================
  Files           97       97              
  Lines         9477     9477              
===========================================
- Hits          7171     7164       -7     
- Misses        1856     1862       +6     
- Partials       450      451       +1     
Impacted Files Coverage Δ
pkg/app/server/hertz.go 73.21% <0.00%> (ø)
pkg/common/errors/errors.go 87.95% <ø> (ø)
pkg/common/stackless/writer.go 88.23% <ø> (ø)
pkg/common/tracer/stats/event.go 92.00% <ø> (ø)
pkg/common/test/mock/network.go 89.84% <100.00%> (ø)
pkg/protocol/request.go 83.85% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/protocol/request.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou force-pushed the optimize/publicerr branch from 8f84105 to 5e6479d Compare May 18, 2023 07:45
pkg/protocol/request.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou force-pushed the optimize/publicerr branch from 6c5d628 to 4d0a80e Compare May 19, 2023 03:43
@li-jin-gou li-jin-gou merged commit 4cfbd22 into cloudwego:develop May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants