Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hz): support extends for thrift #765

Merged
merged 2 commits into from
May 11, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented May 6, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

thrift 支持 extend 关键字来拓展 service 的定义

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: thrift 支持 extends 关键字来拓展 service 的定义
zh(optional): thrift supports the 'extends' keyword to extend the definition of service

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners May 6, 2023 06:46
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (c8ffa58) 75.63% compared to head (0d68726) 75.56%.

❗ Current head 0d68726 differs from pull request most recent head cc30811. Consider uploading reports for the commit cc30811 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #765      +/-   ##
===========================================
- Coverage    75.63%   75.56%   -0.08%     
===========================================
  Files           97       97              
  Lines         9477     9477              
===========================================
- Hits          7168     7161       -7     
- Misses        1859     1865       +6     
- Partials       450      451       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF merged commit 0b9dfea into develop May 11, 2023
@FGYFFFF FGYFFFF deleted the feat/support_extends_for_thrift branch May 11, 2023 06:10
FGYFFFF added a commit that referenced this pull request May 17, 2023
FGYFFFF added a commit that referenced this pull request May 17, 2023
FGYFFFF added a commit that referenced this pull request May 18, 2023
FGYFFFF added a commit that referenced this pull request May 18, 2023
FGYFFFF added a commit that referenced this pull request May 26, 2023
FGYFFFF added a commit that referenced this pull request May 31, 2023
FGYFFFF added a commit that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants