Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hz): compatibility annotations for protobuf #742

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Apr 21, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

为 protobuf 添加兼容性注解

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Add compatibility annotations to protobuf to avoid serial number conflicts
zh(optional): 为 protobuf 添加兼容性注解,避免出现序号冲突

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

https://github.com/cloudwego/cloudwego.github.io/pull/621/commits

@FGYFFFF FGYFFFF requested review from a team as code owners April 21, 2023 07:22
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (65b5207) 75.64% compared to head (0b323c2) 75.72%.

❗ Current head 0b323c2 differs from pull request most recent head 37c1666. Consider uploading reports for the commit 37c1666 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #742      +/-   ##
===========================================
+ Coverage    75.64%   75.72%   +0.07%     
===========================================
  Files           97       97              
  Lines         9462     9462              
===========================================
+ Hits          7158     7165       +7     
+ Misses        1855     1849       -6     
+ Partials       449      448       -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF force-pushed the feat/annotation_compatilbe branch 4 times, most recently from fffe7b5 to a8ad97d Compare April 21, 2023 07:41
cmd/hz/protobuf/ast.go Outdated Show resolved Hide resolved
@FGYFFFF FGYFFFF force-pushed the feat/annotation_compatilbe branch from a8ad97d to 37c1666 Compare April 21, 2023 08:14
@FGYFFFF FGYFFFF merged commit 03273e1 into develop Apr 23, 2023
@FGYFFFF FGYFFFF deleted the feat/annotation_compatilbe branch April 23, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants