Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: uniform error creation #668

Merged
merged 9 commits into from
May 19, 2023

Conversation

justlorain
Copy link
Member

What type of PR is this?

optimize: A new optimization

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: use package common/errors method to create error
zh(optional): 统一使用 common/errors 包的方法来创建 error

Which issue(s) this PR fixes:

null

@justlorain justlorain requested review from a team as code owners March 14, 2023 11:14
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.04 ⚠️

Comparison is base (62aa1a0) 75.66% compared to head (8d1251b) 75.63%.

❗ Current head 8d1251b differs from pull request most recent head c6da5c4. Consider uploading reports for the commit c6da5c4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #668      +/-   ##
===========================================
- Coverage    75.66%   75.63%   -0.04%     
===========================================
  Files           97       97              
  Lines         9477     9477              
===========================================
- Hits          7171     7168       -3     
- Misses        1856     1859       +3     
  Partials       450      450              
Impacted Files Coverage Δ
pkg/app/server/hertz.go 73.21% <0.00%> (ø)
pkg/common/stackless/writer.go 88.23% <ø> (ø)
pkg/common/tracer/stats/event.go 92.00% <ø> (ø)
pkg/common/test/mock/network.go 89.84% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever
Copy link
Member

Any progress about the UT may be updated here🙏 @wzekin

welkeyever
welkeyever previously approved these changes Mar 22, 2023
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

# Conflicts:
#	pkg/common/test/mock/network.go
@justlorain
Copy link
Member Author

The conflict has been resolved :)

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@welkeyever welkeyever requested a review from a team May 15, 2023 09:16
@li-jin-gou li-jin-gou merged commit 062adad into cloudwego:develop May 19, 2023
@justlorain justlorain deleted the optimize_err_format branch May 21, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants