-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: uniform error creation #668
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #668 +/- ##
===========================================
- Coverage 75.66% 75.63% -0.04%
===========================================
Files 97 97
Lines 9477 9477
===========================================
- Hits 7171 7168 -3
- Misses 1856 1859 +3
Partials 450 450
☔ View full report in Codecov by Sentry. |
Any progress about the UT may be updated here🙏 @wzekin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx~
# Conflicts: # pkg/common/test/mock/network.go
The conflict has been resolved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
optimize: A new optimization
Check the PR title.
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: use package common/errors method to create error
zh(optional): 统一使用 common/errors 包的方法来创建 error
Which issue(s) this PR fixes:
null