Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hz): namespace conflict between master and include IDL #533

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Jan 11, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

解决 master IDL 和 include IDL 的 namespace 之间的冲突

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Resolve conflicts between the namespace of master IDL and include IDL
zh(optional): 解决 master IDL 和 include IDL 的 namespace 之间的冲突

Which issue(s) this PR fixes:

@FGYFFFF FGYFFFF requested review from a team as code owners January 11, 2023 08:02
@FGYFFFF FGYFFFF force-pushed the fix/namespace_conflict branch from 412081c to 83cf183 Compare January 11, 2023 08:22
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 69.75% // Head: 69.87% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (83cf183) compared to base (67eb00d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #533      +/-   ##
===========================================
+ Coverage    69.75%   69.87%   +0.12%     
===========================================
  Files           93       93              
  Lines         8878     8887       +9     
===========================================
+ Hits          6193     6210      +17     
+ Misses        2315     2307       -8     
  Partials       370      370              
Impacted Files Coverage Δ
pkg/protocol/header.go 75.59% <0.00%> (+0.65%) ⬆️
pkg/protocol/cookie.go 88.47% <0.00%> (+2.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou li-jin-gou merged commit 327716b into cloudwego:develop Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants